Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36840 )
Change subject: soc/intel/skylake: Clean up report_cpu_info() function ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36840/1/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/36840/1/src/soc/intel/skylake/bootb... PS1, Line 179: cpu_not_found
this is a const char array.
Done
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb... PS2, Line 170: "Platform info not available"
fill_processor_name always overwrites this.
Done
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb... PS2, Line 177: fill_processor_name(cpu_name);
You need to have at least a 49 (3 * 12 + 4 + 1) char array size.
Done