Attention is currently required from: Joel Kitching, Andrey Pronin, Aseda Aboagye, Aaron Durbin.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52919 )
Change subject: vboot/secdata_tpm: Create FWMP space in coreboot
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/52919/comment/d894f8e6_4e2cd975
PS1, Line 420: /*
: * Set initial values of secdata_firmware space.
: * kernel space is created in _factory_initialize_tpm().
: */
: vb2api_secdata_firmware_create(ctx);
Does anyone know if there's any particular reason this is done prior to _factory_initialize_tpm()? I […]
No, shouldn't be. I think this was just put here to minimize duplication between TPM1/TPM2 parts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f566e00f11046ff9a9891c65660af50fbb83675
Gerrit-Change-Number: 52919
Gerrit-PatchSet: 7
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Sat, 15 May 2021 00:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aseda Aboagye
aaboagye@google.com
Gerrit-MessageType: comment