build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32081 )
Change subject: Patch SSDTs into qemu, and add VPD area to the fmap for q35 as a proof of concept ......................................................................
Patch Set 1:
(21 comments)
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.h:
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 17: int is_rsdp(char *); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 256: if(!strncmp(s[i].alloc.file, "etc/acpi/rsdp", 13)) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 257: printk(BIOS_DEBUG, "Found RSDP at 0x%lx\n", current); line over 80 characters
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 331: if(rsdp) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 331: if(rsdp) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 332: ssdt = (acpi_header_t *)current; code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 332: ssdt = (acpi_header_t *)current; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 333: acpi_create_ssdt_generator(ssdt, ACPI_TABLE_CREATOR); code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 333: acpi_create_ssdt_generator(ssdt, ACPI_TABLE_CREATOR); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 334: if (ssdt->length > sizeof(acpi_header_t)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 334: if (ssdt->length > sizeof(acpi_header_t)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 334: if (ssdt->length > sizeof(acpi_header_t)) { suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 335: current += ssdt->length; code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 335: current += ssdt->length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 336: acpi_add_table(rsdp, ssdt); code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 336: acpi_add_table(rsdp, ssdt); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 337: current = acpi_align_current(current); code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 337: current = acpi_align_current(current); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 338: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 338: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32081/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 339: } please, no spaces at the start of a line