Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42070 )
Change subject: mb/google/volteer: Enable CSE Firmware Lite SKU
......................................................................
Patch Set 15: Code-Review-2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte...
File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/42070/12/src/mainboard/google/volte...
PS12, Line 28: SOC_INTEL_CSE_LITE_SKU
Done
@Jamie, that means that we can't set SOC_INTEL_CSE_LITE_SKU here as this setting applies to ALL variants. It must be set only for variants that are not preQS or QS (i.e. all variants should set SOC_INTEL_CSE_LITE_SKU EXCEPT for ripto, volteer2, and delbin).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42070
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f939883617a1271b30c76d41e61113bbdd6ab5b
Gerrit-Change-Number: 42070
Gerrit-PatchSet: 15
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sowmya V
v.sowmya@intel.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 18:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment