Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41719/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41719/5//COMMIT_MSG@11 PS5, Line 11: Why is this Picasso specific? Can’t this be put into common code?
https://review.coreboot.org/c/coreboot/+/41719/5/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/41719/5/src/soc/amd/picasso/include... PS5, Line 20: #define RAVEN1_B0_CPUID 0x00810f10 Looks exactly as above?
https://review.coreboot.org/c/coreboot/+/41719/5/src/soc/amd/picasso/update_... File src/soc/amd/picasso/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/5/src/soc/amd/picasso/update_... PS5, Line 27: int unsigned