Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35623 )
Change subject: TEST-ONLY: Add anx7625 driver ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 219: BIOS_INFO
BIOS_ERROR? And please indicate what may happen (panel won't work?)
Changed to BIOS_ERROR
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 648: pedid_blocks_buf
shouldn't we also pass size of this buffer?
Not sure if we need that.
https://review.coreboot.org/c/coreboot/+/35623/10/src/drivers/analogix/anx76... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/35623/10/src/drivers/analogix/anx76... PS10, Line 224: ANXERROR("pixelclock too high, act(%d), maximum(%lu)\n", Please indicate what may happen (panel won't work?)