Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier.
Maximilian Brune has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87387?usp=email )
Change subject: soc/intel/broadwell: Add CFR objects for existing options ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
File src/soc/intel/broadwell/include/soc/cfr.h:
https://review.coreboot.org/c/coreboot/+/87387/comment/f0580b73_7e9ba551?usp... : PS2, Line 7: BROADWELL_CFR_H nit: I don't know if we have an actual guideline for include guard names, but we usually call them `_BROADWELL_H_`.
https://review.coreboot.org/c/coreboot/+/87387/comment/ed703d79_21b6cc21?usp... : PS2, Line 22: nit: indentation doesn't match the above two lines.
https://review.coreboot.org/c/coreboot/+/87387/comment/fea44b71_066965c8?usp... : PS2, Line 33: nit: unnecessary indentation?