build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45472 )
Change subject: cpu/x86/smm: Add save state ops for different save states. ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/amd/smm/amd64_save_... File src/cpu/amd/smm/amd64_save_state.c:
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/amd/smm/amd64_save_... PS1, Line 57: static int amd64_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t100_... File src/cpu/intel/smm/em64t100_save_state.c:
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t100_... PS1, Line 57: static int em64t100_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t100_... PS1, Line 62: static int em64t100_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t101_... File src/cpu/intel/smm/em64t101_save_state.c:
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t101_... PS1, Line 9: const em64t101_smm_state_save_area_t *save_state = (const em64t101_smm_state_save_area_t *)smm_get_save_state(node); line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t101_... PS1, Line 56: static int em64t101_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/intel/smm/em64t101_... PS1, Line 61: static int em64t101_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/x86/smm/legacy_save... File src/cpu/x86/smm/legacy_save_state.c:
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/x86/smm/legacy_save... PS1, Line 56: static int legacy_get_reg(const enum cpu_reg reg, const int node, void *out, const uint8_t length) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/x86/smm/legacy_save... PS1, Line 61: static int legacy_set_reg(const enum cpu_reg reg, const int node, void *in, const uint8_t length) line over 96 characters