[coreboot-gerrit] Change in coreboot[master]: src/mainboard/ocp/monolake: Create SMBIOS type 16 for Monolake platform

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36764 )

Change subject: src/mainboard/ocp/monolake: Create SMBIOS type 16 for Monolake platform
......................................................................

Patch Set 7:
> Patch Set 7:
>
> (5 comments)
> > Patch Set 6:
> >
> > I'd prefer a common driver for type16 entries. In the last few weeks everybody seem to duplicate those table creation code in mainboard directory.
> > In the end you only need the maximum slot count, DIMM size per slot, soldered memory size and ECC capability. Those can easily be set in the devicetree.
>
> The memory related configurations are not defined in device so far, should I wait for the configurations ready and then write a common driver for SMBIOS type16 entries?

The master will not support Broadwell-DE anymore, I think this change can be cherry-picked to 4.11_branch and continue to hard-coded approach. The better way of setting those values in devicetree can be implemented in master branch in the future.