23 Jan
2020
23 Jan
'20
12:51 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38491 )
Change subject: mainboard/hatch: Fix GPE wake comments ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38491/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38491/1/src/mainboard/google/hatch/... PS1, Line 58: EC wake pin route for the _PRW WoL method.
I don't understand this comment. […]
It doesn't that's another bit of confusion. I fixed that now as well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38491
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35d746a202dae06d2f6f1edfaa3889864b09f50d
Gerrit-Change-Number: 38491
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jan 2020 23:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment