[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/helios: Modify DPTF parameters

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35794 )

Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters
......................................................................

Patch Set 2:

(2 comments)
> Patch Set 2:
> > Patch Set 2:
> >
> > (1 comment)
>
> Set 0 means set null . It will make passive setting disabled by filled value 0 .

Does that mean, you do not want any kind of passive throttling (PL1) when CPU, TSR1 and TSR2 goes above passive temperature threshold limits ?

https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/... 
PS2, Line 65: Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 },	/* 0.5A */
any reason for this removing this ?

https://review.coreboot.org/c/coreboot/+/35794/2/src/mainboard/google/hatch/... 
PS2, Line 93: /* CPU Throttle Effect on CPU */
            : 	Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 60, 0, 0, 0, 0 },
Do you still need this ? Above passive threshold for CPU set to 0.