[coreboot-gerrit] Change in coreboot[master]: nb/intel/{haswell,ironlake,pineview,sandybridge,x4x}: Refactor MCHBAR...

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45487 )

Change subject: nb/intel/{haswell,ironlake,pineview,sandybridge,x4x}: Refactor MCHBARx_AND_OR
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review-1
>
> still getting the same error as the old code
>
> error: overflow in conversion from 'int' to 'u8' {aka 'volatile unsigned char'} changes value from '(int)*4275126567 & -256 | 64' to '64' [-Werror=overflow]
>
> The old MCHBARx_AND_OR and new one are definitely a very bad idea!

Overflow error fixed here: https://review.coreboot.org/c/coreboot/+/45517