Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32326 )
Change subject: kohaku: mb/hatch/gpio: Scrub Kohaku GPIOs. ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
PS3:
This file needs to be added to Makefile. […]
Done
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... PS3, Line 21: gpio_table
From the implementation, it looks like you are intending to treat this as an override table? If yes, […]
I see. Based on octopus, I had thought that providing the override table would just work. I think the base + override method is the way to go, so I will update to use that.
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... PS3, Line 87: ACPI_S5
There is no need to distinguish sleep type if there is only one sleep gpio table.
Done
https://review.coreboot.org/#/c/32326/3/src/mainboard/google/hatch/variants/... PS3, Line 92: default_sleep_gpio_table
Where is this defined?
Oops. Not here.