Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41577 )
Change subject: soc/amd/picasso: Give the mainboard the ability to modify the MADT table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41577/1/src/soc/amd/picasso/acpi.c
File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/41577/1/src/soc/amd/picasso/acpi.c@...
PS1, Line 40: unsigned long __weak acpi_mb_madt_irqoverride(unsigned long current)
Why is the ACPI table creation directly exposed? Can't we drive this through configuration tables instead of making the mainboards implement the proper sequence?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie95e8cc7ca835fb60bee8f10d5f28def6c2801dc
Gerrit-Change-Number: 41577
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 May 2020 21:32:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment