Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38836 )
Change subject: security/intel/stm: Check for processor STM support
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38836/3/src/security/intel/stm/StmP...
File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/c/coreboot/+/38836/3/src/security/intel/stm/StmP...
PS3, Line 162: stm_chk
nit: maybe call this vmx_basic ?
https://review.coreboot.org/c/coreboot/+/38836/3/src/security/intel/stm/StmP...
PS3, Line 172: BIOS_WARNING
How bad is it when STM has been enabled, but the CPU does not support it? Can the system still boot successfully? If so, can it run without any security issues, or would it result in security weaknesses?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38836
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I518bb2aa1bdec94b5b6d5e991d7575257f3dc6e9
Gerrit-Change-Number: 38836
Gerrit-PatchSet: 3
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Reinecke
nr@das-labor.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 23:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment