[coreboot-gerrit] [M] Change in coreboot[main]: security/tpm: make tis_probe() return tpm_family

[Martin L Roth (Code Review)]

Attention is currently required from: Christian Walter, Julius Werner, Jérémy Compostella, Michał Żygowski, Sergii Dmytruk.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159?usp=email )

Change subject: security/tpm: make tis_probe() return tpm_family
......................................................................

Patch Set 26: Code-Review+2

(3 comments)

Patchset:

PS26: 
everything here looks good to me, but it wouldn't hurt my feelings to have one of the TPM experts look over the train to make sure I haven't missed anything.

File src/security/tpm/tss/tcg-1.2/tss.c:

https://review.coreboot.org/c/coreboot/+/69159/comment/46ca91ea_27d720c0 :
PS16, Line 165: 	if (family != TPM_1) {
> I think it's good to have even when only one TPM version is supported to validate that found driver  […]

Acknowledged

File src/security/tpm/tss/tcg-2.0/tss.c:

https://review.coreboot.org/c/coreboot/+/69159/comment/32b2ba1d_0b54986c :
PS16, Line 225: if (family != TPM_2) {
> Same as above in `tcg-1.2/tss.c`: […]

Acknowledged