Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 )
Change subject: soc/mediatek: a common implementation to register BL31 reset
......................................................................
Patch Set 4:
(2 comments)
File src/soc/mediatek/common/bl31.c:
https://review.coreboot.org/c/coreboot/+/67359/comment/35686934_59892f13
PS4, Line 3: #include <bl31.h>
: #include <console/console.h>
: #include <soc/bl31.h>
: #include <boot/coreboot_tables.h>
: #include <gpio.h>
in alphabet order
File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67359/comment/611b8048_7006eaf0
PS4, Line 28: ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += ../common/bl31.c
move to ramstage section in the below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf
Gerrit-Change-Number: 67359
Gerrit-PatchSet: 4
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 07:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment