24 Jul
2019
24 Jul
'19
9:51 a.m.
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34518 )
Change subject: src/device/oprom src/lib: Remove broken bootsplash display code ......................................................................
Patch Set 6:
We should also keep in mind, that the current code structure requires Oprom execution. To my understanding it is currently impossbile to get a bootsplash together with native graphics init. So if we were to keep it, maybe it should be moved to src/lib or something alike and call it from all the framebuffer initialization codes.
How are usually decisions like this worked out?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34518
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77619e1a885ed87123f4f5f185969d16d557e490
Gerrit-Change-Number: 34518
Gerrit-PatchSet: 6
Gerrit-Owner: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Christoph Pomaska github@aufmachen.jetzt
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 07:51:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment