Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73335 )
Change subject: soc/amd/picasso/Kconfig: update help text for 2nd VBIOS ID detection
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/73335/comment/ca49e0b6_a41377de
PS2, Line 243: Raven2
Raven2/Dali? Since we don't really support either Raven1 or Raven2, I'm not really sure I'd include […]
i disagree, since this is specific to rv2 silicon that needs a different vbios file. dali can be either pco or rv2 silicon, pollock is always rv2 silicon and picasso is always pco silicon
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia568771ed7dfa0c7bb850b0efcd2959d7ddfd4a1
Gerrit-Change-Number: 73335
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 21:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment