Vladimir Serbinenko (phcoder@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10228
-gerrit
commit 5c2fd26e8217f0eae58542dc1892f6ffd09548e3 Author: Vladimir Serbinenko phcoder@gmail.com Date: Sat May 16 16:36:17 2015 +0200
Remove useless extern gnvs declaration in smi handlers.
Change-Id: I3047badea8d4f61155f4e4f7d3d078426948162a Signed-off-by: Vladimir Serbinenko phcoder@gmail.com --- src/mainboard/apple/macbook21/smihandler.c | 5 ----- src/mainboard/gigabyte/ga-b75m-d3h/mainboard_smi.c | 5 ----- src/mainboard/gigabyte/ga-b75m-d3v/mainboard_smi.c | 5 ----- src/mainboard/lenovo/t420s/smihandler.c | 5 ----- src/mainboard/lenovo/t430s/smihandler.c | 5 ----- src/mainboard/lenovo/t520/smihandler.c | 5 ----- src/mainboard/lenovo/t530/smihandler.c | 5 ----- src/mainboard/lenovo/t60/smihandler.c | 4 ---- src/mainboard/lenovo/x201/smihandler.c | 5 ----- src/mainboard/lenovo/x220/smihandler.c | 5 ----- src/mainboard/lenovo/x230/smihandler.c | 5 ----- src/mainboard/lenovo/x60/smihandler.c | 5 ----- src/mainboard/packardbell/ms2290/smihandler.c | 5 ----- 13 files changed, 64 deletions(-)
diff --git a/src/mainboard/apple/macbook21/smihandler.c b/src/mainboard/apple/macbook21/smihandler.c index 5c6cd44..a43ab26 100644 --- a/src/mainboard/apple/macbook21/smihandler.c +++ b/src/mainboard/apple/macbook21/smihandler.c @@ -29,11 +29,6 @@
#define GPE_EC_SCI 12
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/mainboard_smi.c b/src/mainboard/gigabyte/ga-b75m-d3h/mainboard_smi.c index 448fcc4..45c3524 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/mainboard_smi.c +++ b/src/mainboard/gigabyte/ga-b75m-d3h/mainboard_smi.c @@ -31,11 +31,6 @@ #include <northbridge/intel/sandybridge/sandybridge.h> #include <cpu/intel/model_206ax/model_206ax.h>
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/mainboard_smi.c b/src/mainboard/gigabyte/ga-b75m-d3v/mainboard_smi.c index 448fcc4..45c3524 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/mainboard_smi.c +++ b/src/mainboard/gigabyte/ga-b75m-d3v/mainboard_smi.c @@ -31,11 +31,6 @@ #include <northbridge/intel/sandybridge/sandybridge.h> #include <cpu/intel/model_206ax/model_206ax.h>
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/t420s/smihandler.c b/src/mainboard/lenovo/t420s/smihandler.c index d18552e..0cf999f 100644 --- a/src/mainboard/lenovo/t420s/smihandler.c +++ b/src/mainboard/lenovo/t420s/smihandler.c @@ -36,11 +36,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/t430s/smihandler.c b/src/mainboard/lenovo/t430s/smihandler.c index c22d434..e658155 100644 --- a/src/mainboard/lenovo/t430s/smihandler.c +++ b/src/mainboard/lenovo/t430s/smihandler.c @@ -34,11 +34,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/t520/smihandler.c b/src/mainboard/lenovo/t520/smihandler.c index f651f32..c1f2737 100644 --- a/src/mainboard/lenovo/t520/smihandler.c +++ b/src/mainboard/lenovo/t520/smihandler.c @@ -36,11 +36,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/t530/smihandler.c b/src/mainboard/lenovo/t530/smihandler.c index cd53f06..91bb20e 100644 --- a/src/mainboard/lenovo/t530/smihandler.c +++ b/src/mainboard/lenovo/t530/smihandler.c @@ -36,11 +36,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/t60/smihandler.c b/src/mainboard/lenovo/t60/smihandler.c index 6e46bfd..e25d4ce 100644 --- a/src/mainboard/lenovo/t60/smihandler.c +++ b/src/mainboard/lenovo/t60/smihandler.c @@ -31,10 +31,6 @@ #define GPE_EC_SCI 12
#define LVTMA_BL_MOD_LEVEL 0x7af9 /* ATI Radeon backlight level */ -/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs;
static void mainboard_smm_init(void) { diff --git a/src/mainboard/lenovo/x201/smihandler.c b/src/mainboard/lenovo/x201/smihandler.c index 35d9605..1bd7766 100644 --- a/src/mainboard/lenovo/x201/smihandler.c +++ b/src/mainboard/lenovo/x201/smihandler.c @@ -37,11 +37,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/x220/smihandler.c b/src/mainboard/lenovo/x220/smihandler.c index cd53f06..91bb20e 100644 --- a/src/mainboard/lenovo/x220/smihandler.c +++ b/src/mainboard/lenovo/x220/smihandler.c @@ -36,11 +36,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/x230/smihandler.c b/src/mainboard/lenovo/x230/smihandler.c index e2e98ae..d77e0d5 100644 --- a/src/mainboard/lenovo/x230/smihandler.c +++ b/src/mainboard/lenovo/x230/smihandler.c @@ -36,11 +36,6 @@ #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/lenovo/x60/smihandler.c b/src/mainboard/lenovo/x60/smihandler.c index be6efce..c037dfa 100644 --- a/src/mainboard/lenovo/x60/smihandler.c +++ b/src/mainboard/lenovo/x60/smihandler.c @@ -33,11 +33,6 @@
#define GPE_EC_SCI 12
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n"); diff --git a/src/mainboard/packardbell/ms2290/smihandler.c b/src/mainboard/packardbell/ms2290/smihandler.c index 5cc692b..b883872 100644 --- a/src/mainboard/packardbell/ms2290/smihandler.c +++ b/src/mainboard/packardbell/ms2290/smihandler.c @@ -31,11 +31,6 @@ #include <pc80/mc146818rtc.h> #include <delay.h>
-/* The southbridge SMI handler checks whether gnvs has a - * valid pointer before calling the trap handler - */ -extern global_nvs_t *gnvs; - static void mainboard_smm_init(void) { printk(BIOS_DEBUG, "initializing SMI\n");