[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )

Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
......................................................................

Patch Set 1:
> Hi Nico, are you telling us that when you choose to use Fsp-Car

No, I did not "choose" it. It is the default unless you work
on Google's boards.
> and with your config will pump into getting
> CPU_MICROCODE_CBFS_LEN and _LOC = 0? With that causing you
> having boot failure?

Again, not my config, but the defaults are 0. I only assumed
that this is what is causing the failure, but I don't know it
for sure. It's also possible that FSP-T is more broken or that
some other default setting is wrong.

I'm not really looking for a way to make FSP-T work. FSP-T
is a disgrace to coreboot. I don't care about it. What I do
care about is working default settings.

In coreboot (the real coreboot without FSP), for most boards
one simply has to select the mainboard vendor and model. If
you leave everything else at its default, you get a bootable
firmware. Alas, the FSP integration into coreboot is still
five or six years behind in terms of quality.