Hello Chen Wisley, Justin TerAvest, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34309
to review the following change.
Change subject: Revert "mb/google/octopus: Disable WLAN prior the entry of S5" ......................................................................
Revert "mb/google/octopus: Disable WLAN prior the entry of S5"
This reverts commit 38dbd6892080c93ccd24fbfa46ed5d9bdb7d9e99.
Reason for revert: <INSERT REASONING HERE> ODM helped to verify w/ BT runtime suspend disabled + revert this change And issue is gone. so I revert this change
see the test result in https://partnerissuetracker.corp.google.com/issues/136039607#comment32
thanks
Change-Id: I248e9613cc39247a2bb88270c234c7d36d0ff60f --- M src/mainboard/google/octopus/variants/baseboard/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34309/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 3305c02..5326118 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -341,8 +341,6 @@ static const struct pad_config sleep_s5_gpio_table[] = { /* BT_DISABLE_L */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 0, DEEP, NONE, Tx0RxDCRx1, SAME), - /* WLAN_DISABLE_L */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 0, DEEP, NONE, Tx0RxDCRx1, SAME), };
const struct pad_config *__weak