build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31049 )
Change subject: src: Don't use a #defines like Kconfig symbols ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31049/5/src/soc/rockchip/rk3288/sdram.c File src/soc/rockchip/rk3288/sdram.c:
https://review.coreboot.org/#/c/31049/5/src/soc/rockchip/rk3288/sdram.c@912 PS5, Line 912: case CONF: Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/31049/5/src/superio/smsc/lpc47n207/early_ser... File src/superio/smsc/lpc47n207/early_serial.c:
https://review.coreboot.org/#/c/31049/5/src/superio/smsc/lpc47n207/early_ser... PS5, Line 61: if (reg_value != CONF_ENABLE) { braces {} are not necessary for single statement blocks