Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
......................................................................
Patch Set 6:
Patch Set 6:
I still do not like -lga1151- in the mainboard name. Two hours after -series was merged, you realised that name did not work after all... As noted earlier, I don't have strong opinions about this but new naming schemes should be argumented a bit better.
I am totally agreeing with you ;). But nvm - there was a discussion at IRC and it has been decided to merge this into the tree. So let's try to tune the naming such that it fits better. And lets not start the discussion again about if it should be in the tree anyways. If you dont want it there, revert the patch and discuss it there. :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573
Gerrit-Change-Number: 35622
Gerrit-PatchSet: 6
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 26 Sep 2019 15:46:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment