[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 7: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/7/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/48286/7/src/soc/intel/common/block/... 
PS7, Line 416: edi
> Yes Furquan. I was testing the change yesterday. I observed the system hang with original change. […]

Ah yes, that is right!! wrmsr requires register address in ecx.

This looks okay. Just one comment:
Using edi to back up the number of ways can be done under #if CONFIG(CAR_HAS_SF_MASKS) and restoring back to ecx just before the #endif. This way, the save/restore would only be required for CAR_HAS_SF_MASKS.