Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42786 )
Change subject: mb/amd: Add Pollock CRB Cereme as Mandolin variant ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... PS21, Line 13: # TODO: provide separate APCB for Cereme
I guess this would need to be handled at some point?
it should be, but the APCB from mandolin also works for cereme. so while this should be done, it doesn't need to be done in order for this patch to land
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/variants/cereme/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... PS21, Line 4: ../../gpio.h
IMHO, I find the baseboard subdir in `variants/` quite confusing. […]
in zork the baseboard thing makes much more sense than here imho, since there aren't multiple mandolin or cereme variants, but there are multiple variants of the two zork base boards