Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: remove unnecessary code and comments for x230s ......................................................................
mainboard/lenovo/x230: remove unnecessary code and comments for x230s
There are some unnecessary code and comments remaining before x230s support ( https://review.coreboot.org/c/coreboot/+/41168 ) gets accepted.
This commit will remove them.
Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/variants/x230s/early_init.c M src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads 2 files changed, 1 insertion(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/41390/1
diff --git a/src/mainboard/lenovo/x230/variants/x230s/early_init.c b/src/mainboard/lenovo/x230/variants/x230s/early_init.c index 0b4c084..17810fc 100644 --- a/src/mainboard/lenovo/x230/variants/x230s/early_init.c +++ b/src/mainboard/lenovo/x230/variants/x230s/early_init.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* FIXME: Check if all includes are needed. */ - #include <stdint.h> #include <string.h> #include <timestamp.h> @@ -33,17 +31,7 @@ { 1, 1, -1 }, };
-void bootblock_mainboard_early_init(void) -{ - pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); - pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); -} - -/* FIXME: Put proper SPD map here. */ void mainboard_get_spd(spd_raw_data *spd, bool id_only) { read_spd(&spd[0], 0x50, id_only); - read_spd(&spd[1], 0x52, id_only); - read_spd(&spd[2], 0x51, id_only); - read_spd(&spd[3], 0x53, id_only); } diff --git a/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads b/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads index fb75293..fd2a5d5 100644 --- a/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads +++ b/src/mainboard/lenovo/x230/variants/x230s/gma-mainboard.ads @@ -16,7 +16,7 @@ HDMI2, HDMI3, Analog, - EDP, + eDP, others => Disabled);
end GMA.Mainboard;