Attention is currently required from: Won Chung.
Emilie Roberts has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81089?usp=email )
Change subject: drivers/intel/pmc_mux/conn: Copy ACPI _PLD property from USB port to mux
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
printk says:
```
added type-c port0 info to cbmem: usb2:3 usb3:3 sbu:0 data:0
added type-c port1 info to cbmem: usb2:2 usb3:2 sbu:0 data:0
```
Enumeration looks right here (port 0 => usb 3), (port 1 => usb3 2).
I'm not sure where the sequential assumption is happening but we seem to be processing port0 but getting the first usb3 value by accident.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If27042cc995ef188f8a3e31444e994318ff98803
Gerrit-Change-Number: 81089
Gerrit-PatchSet: 5
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benson Leung
bleung@google.com
Gerrit-CC: Emilie Roberts
hadrosaur@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prashant Malani
pmalani@chromium.org
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Attention: Won Chung
wonchung@google.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 15:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment