Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47308/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47308/4//COMMIT_MSG@10 PS4, Line 10: This allows initialization of the : fingerprint GPIOs which need to be handled differently between wake : from S3 and boot from S5.
What are these requirements? Can you please capture those in the commit message?
Sure, I'll add it.
On initial boot, the state of the FP sensor could be either enabled or disabled. Because of this, on boot, we power off the sensor for >200ms, to reset its state, then power it back on.
In suspend/resume, the fingerprint sensor should remain powered the entire time.
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v... PS4, Line 300: gpio_fingerprint_poweron_table
Dear Furquan, […]
The power enable and reset get enabled at the end of the boot process. See cb:47310