Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35077 )
Change subject: security/vboot: Decouple measured boot from verified boot ......................................................................
Patch Set 21:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Makefile... PS5, Line 17: ifneq ($(CONFIG_VBOOT_MEASURED_BOOT)$(CONFIG_VBOOT),)
Rather than building it for both vboot and measured boot, I think we should build and link the vboot […]
The another change to modify how vboot library is built is CB:37787.
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Makefile... PS5, Line 59: endif # CONFIG_VBOOT_MEASURED_BOOT || CONFIG_VBOOT
This is where the ifneq ($(CONFIG_VBOOT),) should start. […]
Done
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Makefile... PS5, Line 61: ifeq ($(CONFIG_VBOOT_MEASURED_BOOT),y)
This is the stuff that should go into another directory.
Done
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Makefile... PS5, Line 69: ifeq ($(CONFIG_VBOOT),y)
(Slightly off-topic, but this ifeq seems to be pointless because CONFIG_VBOOT should always be y her […]
Done