Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49187 )
Change subject: soc/intel/jasperlake: Update acoustic noise related parameters ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/49187/3/src/soc/intel/jasperlake/ch... File src/soc/intel/jasperlake/chip.h:
https://review.coreboot.org/c/coreboot/+/49187/3/src/soc/intel/jasperlake/ch... PS3, Line 356: VR domains VCCIN VR domain
https://review.coreboot.org/c/coreboot/+/49187/3/src/soc/intel/jasperlake/ch... PS3, Line 363: VR domains VCCIN VR domain
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49187/1/src/soc/intel/jasperlake/fs... PS1, Line 244: 0
Done
Thanks Maulik!
https://review.coreboot.org/c/coreboot/+/49187/3/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49187/3/src/soc/intel/jasperlake/fs... PS3, Line 243: if (params->AcousticNoiseMitigation) { Can you please add a comment here as well that there is a single VR domain i.e. VCCIN?