Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43411 )
Change subject: mb/razer/blade_stealth_kbl: 3/3 Convert field macros to PAD_CFG ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43411/14/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_kbl/gpio.h:
https://review.coreboot.org/c/coreboot/+/43411/14/src/mainboard/razer/blade_... PS14, Line 9: /* : * Bidirectional GPIO port when both RX and TX buffer is enabled : * TODO: move this macros to src/soc/intel/common/block/include/intelblocks/gpio_defs.h : */ : #ifndef PAD_CFG_GPIO_BIDIRECT : #define PAD_CFG_GPIO_BIDIRECT(pad, val, pull, rst, trig, own) \ : _PAD_CFG_STRUCT(pad, \ : PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_TRIG(trig) | \ : PAD_BUF(NO_DISABLE) | val, \ : PAD_PULL(pull) | PAD_CFG_OWN_GPIO(own)) : #endif
todo
Done