Hello build bot (Jenkins), Furquan Shaikh, Marshall Dawson, Andrey Petrov, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44406
to look at the new patch set (#2).
Change subject: drivers/intel/fsp2_0: add Kconfig for separate stack in DRAM ......................................................................
drivers/intel/fsp2_0: add Kconfig for separate stack in DRAM
soc/amd/picasso selected FSP_USES_CB_STACK even though it is FSP 2.0 based, so it doesn't reuse coreboot's stack, but sets up its own stack. In contrast to all other FSP 2.0 based platforms, this stack isn't in the CAR region, since AMD Picasso doesn't support CAR and the DRAM is already available when the x86 cores are released from reset. Selecting FSP_USES_CB_STACK ended up doing the right thing, but is semantically wrong. This patch introduces the new Kconfig option FSP_USES_STACK_IN_DRAM that will also result in the right code path in the FSP driver being taken.
BUG=b:155501050 TEST=Mandolin still boots.
Change-Id: Icd0ff8e17a535e2c247793b64f4b0565887183d8 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/memory_init.c M src/soc/amd/picasso/Kconfig 3 files changed, 19 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/44406/2