Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32280
Change subject: mb/google/sarien: Update SMBIOS type17 ......................................................................
mb/google/sarien: Update SMBIOS type17
Make SMBIOS type 17 device locator to be match with motherboard silkscreen, using "DIMM-A" and "DIMM-B" instead of "Channel-0-DIMM-0" and "Chaneek-1-DIMM-0".
TEST=Boot up with sarien platform and run dmidecode to check SMBIOS type 17 have expected output.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie2125c0381bd24d96f725f68cde93a53da8c94c8 --- M src/mainboard/google/sarien/ramstage.c 1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/32280/1
diff --git a/src/mainboard/google/sarien/ramstage.c b/src/mainboard/google/sarien/ramstage.c index 96321f8..e1fe62b 100644 --- a/src/mainboard/google/sarien/ramstage.c +++ b/src/mainboard/google/sarien/ramstage.c @@ -14,11 +14,33 @@ */
#include <arch/acpi.h> +#include <smbios.h> #include <soc/gpio.h> #include <soc/ramstage.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
+/* mainboard silk screen shows DIMM-A and DIMM-B */ +void smbios_fill_dimm_locator(const struct dimm_info *dimm, + struct smbios_type17 *t) +{ + switch(dimm->channel_num) { + case 0: + t->device_locator = smbios_add_string(t->eos, + "DIMM-A"); + break; + case 1: + t->device_locator = smbios_add_string(t->eos, + "DIMM-B"); + break; + default: { + t->device_locator = smbios_add_string(t->eos, + "UNKOWN"); + break; + } + } +} + void mainboard_silicon_init_params(FSP_S_CONFIG *params) { const struct pad_config *gpio_table;