Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )
Change subject: binaryPI: implement C bootblock ......................................................................
Patch Set 26:
(3 comments)
Squash CB:37331 and CB:37450 with this one?
https://review.coreboot.org/c/coreboot/+/36914/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36914/26//COMMIT_MSG@7 PS26, Line 7: binaryPI: implement C bootblock AGESA, binaryPI: ....
https://review.coreboot.org/c/coreboot/+/36914/26/src/cpu/amd/agesa/Kconfig File src/cpu/amd/agesa/Kconfig:
https://review.coreboot.org/c/coreboot/+/36914/26/src/cpu/amd/agesa/Kconfig@... PS26, Line 71: Unless we squash fam14-16 here, this is at wrong place.
https://review.coreboot.org/c/coreboot/+/36914/26/src/cpu/amd/pi/Kconfig File src/cpu/amd/pi/Kconfig:
https://review.coreboot.org/c/coreboot/+/36914/26/src/cpu/amd/pi/Kconfig@61 PS26, Line 61: default 0x30000 The HEAP ones weren't necessary after all?