Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 )
Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61354/comment/3bab88da_d4eeec96 PS10, Line 11: It would be good to mention the explicit dependency on having a `soc/intel/common/block/pcie/rtd3` chip driver and device under the same parent in the devicetree here and in fact that this driver builds on that one?
File src/drivers/wwan/fm/Kconfig:
https://review.coreboot.org/c/coreboot/+/61354/comment/b782e1f1_f7929d2c PS10, Line 9: Right now there is an explicit dependency on also having a `soc/intel/common/block/pcie/rtd3` chip driver and device under the same parent in the devicetree ?
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/61354/comment/e81455a5_d241a594 PS10, Line 103: : /* : Generate second half reset flow (SHRF) method. : */ ``` /* * Generate second half reset flow (SHRF) method. */ ```
File src/drivers/wwan/fm/chip.h:
https://review.coreboot.org/c/coreboot/+/61354/comment/374e1935_0220257c PS10, Line 21: RTD3 It points to the RP right? maybe: `PCIe RP device` ?