build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30509 )
Change subject: soc/amd/common: Don't use CAR_GLOBAL
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30509/5/src/soc/amd/stoneyridge/spi.c
File src/soc/amd/stoneyridge/spi.c:
https://review.coreboot.org/#/c/30509/5/src/soc/amd/stoneyridge/spi.c@38
PS5, Line 38: spibar = base;
code indent should use tabs where possible
https://review.coreboot.org/#/c/30509/5/src/soc/amd/stoneyridge/spi.c@38
PS5, Line 38: spibar = base;
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I422d5637caa1b55fa6bad30d25f5e34cbba40851
Gerrit-Change-Number: 30509
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 10 Feb 2019 21:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment