Sindhoor Tilak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43000 )
Change subject: post_code: add missing postcode calls ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43000/2/src/arch/x86/bootblock_crt0... File src/arch/x86/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/43000/2/src/arch/x86/bootblock_crt0... PS2, Line 26: mov %eax, %ebx
Ack
Placed it below the mov instruction to prevent changes to %eax
https://review.coreboot.org/c/coreboot/+/43000/2/src/arch/x86/bootblock_crt0... PS2, Line 48: movd %eax, %mm0
Ack
Added extra mov instructions to leave the value in %eax unchanged
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p3/cache_... File src/cpu/intel/car/p3/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p3/cache_... PS2, Line 23: post_code(POST_CAR_FIXED_MTRR)
Ack
Done
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p4-netbur... File src/cpu/intel/car/p4-netburst/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/43000/2/src/cpu/intel/car/p4-netbur... PS2, Line 26: post_code(POST_CAR_FIXED_MTRR)
Ack
Done