[coreboot-gerrit] Change in coreboot[master]: mainboard/google: Allow Hatch variants to read SPD data over SMBus

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36449 )

Change subject: mainboard/google: Allow Hatch variants to read SPD data over SMBus
......................................................................

Patch Set 9:

I just stumbled across this. If you introduce some logic for board variants to select between CBFS/SMBUS source for SPD, I strongly feel it should not be implemented under mainboard/. Maybe not even under cannonlake/ or soc/intel but lib/. The requirement seems very much vendor-agnostic to me.