Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44915 )
Change subject: drivers/intel/usb4: Add driver for USB4 PCIe root port ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... File src/drivers/intel/usb4/pcie/chip.h:
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 9: USB port number
as far as I can tell this is defined in the soc at a platform level but not in any place that I've s […]
We don't have a really great name for this identifier 😞 I'll add a comment.
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... File src/drivers/intel/usb4/pcie/pcie.c:
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 17: struct
const
Done
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 17: dev->chip_info;
config_of(dev)
Done
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 23: if (!config->usb4_port)
I didn't initially because these should be set at the soc level and not be an issue at the mainboard […]
Done
https://review.coreboot.org/c/coreboot/+/44915/2/src/drivers/intel/usb4/pcie... PS2, Line 29: return;
Print error in this case?
Done