Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44261 )
Change subject: mb/google/volteer: Implement variant_devtree_update for volteer sku's ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44261/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/variant.c:
https://review.coreboot.org/c/coreboot/+/44261/7/src/mainboard/google/voltee... PS7, Line 15: (sku_id == 3) || (sku_id == 5)
We have moved to using FW_CONFIG instead of SKU_ID for determining features that firmware cares abou […]
I used this cause this info seems to be alreday in the cbi info. If i add some extra bit for sku info again in fw_config then won't that be a repetition. Please suggest