[coreboot-gerrit] Change in coreboot[master]: sc7180: Add AOP firmware support

[mturney mturney (Code Review)]

mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35502 )

Change subject: sc7180: Add AOP firmware support
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35502/11/src/soc/qualcomm/sc7180/in... 
File src/soc/qualcomm/sc7180/include/soc/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/35502/11/src/soc/qualcomm/sc7180/in... 
PS11, Line 70: 	REGION(dram_aop,  0x80800000, 0x040000, 0x1000)
> SDM845 didn't have this, what is this? Can we make it contiguous with the other reserved area?

I can't speak to why this is different between Rennell and Napali other than cite hardware deltas.
However the Rennell memory map lists an AOP region both in SRAM and DRAM that must be reserved.
The areas we have set aside in memlayout.ld are consistent with the internal memory layout of the chip.