Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib ......................................................................
Patch Set 3:
(5 comments)
File payloads/libpayload/include/arm64/arch/io.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119135): https://review.coreboot.org/c/coreboot/+/53903/comment/5931baf4_8c8392fb PS3, Line 154: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119135): https://review.coreboot.org/c/coreboot/+/53903/comment/40b429e7_194b113d PS3, Line 159: } void function return statements are not generally useful
File src/commonlib/include/commonlib/coreboot_tables.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119135): https://review.coreboot.org/c/coreboot/+/53903/comment/4ea172a7_b2d1deb1 PS3, Line 332: uint32_t tag; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119135): https://review.coreboot.org/c/coreboot/+/53903/comment/fb54b93d_f95c8a26 PS3, Line 333: uint32_t size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119135): https://review.coreboot.org/c/coreboot/+/53903/comment/d4a8149b_55a9fd93 PS3, Line 334: void *config_base; please, no spaces at the start of a line