Attention is currently required from: Nico Huber, Martin L Roth, Benjamin Doron, Michał Kopeć, Angel Pons, Maximilian Brune, Arthur Heymans, Werner Zeh.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68944 )
Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block
......................................................................
Patch Set 15:
(4 comments)
File src/soc/intel/common/block/oc_wdt/Kconfig:
https://review.coreboot.org/c/coreboot/+/68944/comment/a3117689_9d246506
PS15, Line 8: chipset
overclocking
Done
https://review.coreboot.org/c/coreboot/+/68944/comment/a3de47f3_dd5180ce
PS15, Line 18: Watchdog
Overclocking watchdog
Done
File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/68944/comment/6c865b0e_d9c863b9
PS15, Line 215: pmc_clear_pm1_status();
Yeah, have to get rid of that.
Done
File src/soc/intel/common/block/smm/smm.c:
https://review.coreboot.org/c/coreboot/+/68944/comment/82c73aff_1cfdce09
PS15, Line 45: Also we do not allow timeouts lower than 60s
Forced by Kconfig range definition
Added it to the comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68944
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib494aa0c7581351abca8b496fc5895b2c7cbc5bc
Gerrit-Change-Number: 68944
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 14:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment