Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25345 )
Change subject: soc/amd/stoneyridge: Generate SPCR table
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25345/6/src/soc/amd/stoneyridge/uar...
File src/soc/amd/stoneyridge/uart.c:
https://review.coreboot.org/c/coreboot/+/25345/6/src/soc/amd/stoneyridge/uar...
PS6, Line 41: AMDCZ
Works for me, not that I will get to this any time soon... […]
I think we can remove all the special AMDCZ handling. The AMD part uses DW IP. The driver supports reading the fixed clock rate: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
So if we pass that along then I think the kernel will configure the IP correctly so we can boot with console=ttyS0 even when coreboot hasn't setup the UART.
I need to try this out on zork.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc98bcf4f8c070b8002bcc795254b19f928c741b
Gerrit-Change-Number: 25345
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Comment-Date: Tue, 02 Jun 2020 15:25:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment