build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 37: if (CONFIG(RT1015_I2C_MODE)) suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 38: lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 38: lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47586/2/src/mainboard/google/kukui/... PS2, Line 39: else suspect code indent for conditional statements (8, 12)