Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44796 )
Change subject: gma baytrail: Add power and clocks support ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... File common/valleyview/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 69: return (Ref_Freq + Ref_Freq) / Int64 (Divider + 1); Nit, I915 uses a div-round-closest, we probably should too (it's not as bad as we are 3 digits more accurate anyway). Not sure if we have such a function in libhwbase yet for Int64.
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 117: Config.Max_CDClk := 400_000_000; This should match `CDClk` until switching is implemented.
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 121: Nit, remove empty line.