Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sridhar Siricilla, Aseda Aboagye, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57295 )
Change subject: soc/intel/common/cse: Add argument for CSE fixed client addr ......................................................................
Patch Set 7:
(3 comments)
File src/soc/intel/apollolake/cse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127374): https://review.coreboot.org/c/coreboot/+/57295/comment/0b54977c_c5594318 PS7, Line 82: if (!heci_send_receive(&msg, sizeof(msg), &rmsg, &reply_size , HECI_MKHI_ADDR)) { space prohibited before that ',' (ctx:WxW)
File src/soc/intel/common/block/cse/cse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127374): https://review.coreboot.org/c/coreboot/+/57295/comment/466282be_3a5f6a36 PS7, Line 390: * In case of error heci_reset() may be requiered. 'requiered' may be misspelled - perhaps 'required'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127374): https://review.coreboot.org/c/coreboot/+/57295/comment/035f5c93_e9d33c95 PS7, Line 501: * In case of error heci_reset() may be requiered. 'requiered' may be misspelled - perhaps 'required'?