Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/19550 )
Change subject: mb/google/eve: Remove code to set keyboard backlight at boot ......................................................................
mb/google/eve: Remove code to set keyboard backlight at boot
Remove the code that was enabling the keyboard backlight at boot since this is not desired behavior for this device.
BUG=b:35581264 TEST=build and boot on Eve and ensure keyboard backlight does not turn on when booting but can still be enabled in the OS.
Change-Id: I7229cf962597c0de74dc005f7afb9408f7a66f42 Signed-off-by: Duncan Laurie dlaurie@chromium.org Reviewed-on: https://review.coreboot.org/19550 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/eve/bootblock.c 1 file changed, 0 insertions(+), 10 deletions(-)
Approvals: Aaron Durbin: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/eve/bootblock.c b/src/mainboard/google/eve/bootblock.c index 872825f..5e92bb0 100644 --- a/src/mainboard/google/eve/bootblock.c +++ b/src/mainboard/google/eve/bootblock.c @@ -14,13 +14,10 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <bootblock_common.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <soc/gpio.h> -#include <soc/iomap.h> -#include <soc/pm.h> #include "gpio.h"
static void early_config_gpio(void) @@ -30,12 +27,5 @@
void bootblock_mainboard_init(void) { - uint32_t pm1_cnt = inl(ACPI_BASE_ADDRESS + PM1_CNT); - uint32_t pm1_sts = inl(ACPI_BASE_ADDRESS + PM1_STS); - - /* Turn on keyboard backlight to indicate we are booting */ - if (!((pm1_sts & WAK_STS) && (acpi_sleep_from_pm1(pm1_cnt) == ACPI_S3))) - google_chromeec_kbbacklight(75); - early_config_gpio(); }