Attention is currently required from: EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52185 )
Change subject: mb/google/brya: Add FPMCU power control ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52185/comment/2e90b42b_d8fc2ffe PS1, Line 196: register "has_power_resource" = "1" This won't work right now, b/c this will generate a power resource which will let the kernel put the device in D3 for S0ix or S3 (which we don't want, b/c it's a wake source 😊). I have some WIP patches/ideas to improve power resources in coreboot; AFAICT it is possible to describe a power resource which will just power-sequence the device on into D0, but not put into D3 during suspend. tl;dr this won't work right now, coreboot still has to do the power sequencing manually (or you could add some ASL to do it)